[Trilinos-Users] [EXTERNAL] minor bug report

[Andrey Prokopenko]

Karen,

In zoltan2/src/CMakeLists.txt I see

APPEND_GLOB(HEADERS ${DIR}/input/*.hpp)
APPEND_GLOB(SOURCES ${DIR}/input/*.cpp)

So the pamgen adapter header is included in the installation even if 
pamgen is disabled. I think it works right now because it is header 
only. I think it would still be a good idea to guard the code, or this 
glob append.

-Andrey
On 02/20/2015 02:23 PM, Devine, Karen D wrote:
>
> Thanks for your quick response to John, Andrey.
>
>
> You are correct that Trilinos_ASSERT_MISSING_PACKAGES=OFF is needed.
>
>
> Pamgen is a required dependence only for Zoltan2's testing. It is 
> needed only when Zoltan2_ENABLE_TESTS=ON. I am checking with the 
> frameworks people about why Pamgen is enabled even when 
> Zoltan2_ENABLE_TESTS=OFF.
>
>
> Zoltan2_PamgenMeshAdapter.hpp requires Pamgen, but it is included only 
> by test programs that are not compiled when Zoltan2_ENABLE_TESTS=OFF. 
> Also, Zoltan2_PamgenMeshAdapter.hpp does not control the build of 
> Pamgen; that happens at the CMake/Tribits level. So I don't think 
> additional guards are needed (although they wouldn't hurt anything 
> either).
>
>
> Thanks again.
>
> Karen
>
>
>
>
>
> ------------------------------------------------------------------------
> *From:* trilinos-users-bounces at software.sandia.gov 
> <trilinos-users-bounces at software.sandia.gov> on behalf of Andrey 
> Prokopenko <aprokop at sandia.gov>
> *Sent:* Friday, February 20, 2015 10:24 AM
> *To:* Biddiscombe, John A.
> *Cc:* trilinos-users at software.sandia.gov
> *Subject:* Re: [Trilinos-Users] [EXTERNAL] minor bug report
> Hi John,
>
> To ignore missing packages (like claps in your case), add
>   -D Trilinos_ASSERT_MISSING_PACKAGES=OFF
> to your configure line.
>
> Regarding Zoltan2, I'm not sure. The Dependencies.cmake has only 
> Zoltan2 tests requiring pamgen, but the src/input is unconditionally 
> compiled. I think you are right, and the pamgen mesh adapter should be 
> guarded with something like HAVE_ZOLTAN2_PAMGEN.
>
> -Andrey
> On 02/20/2015 03:14 AM, Biddiscombe, John A. wrote:
>> Wanting to build zoltan2 without everything else, I tried
>>
>> cmake  -D BUILD_TESTING:BOOL=OFF   -D Trilinos_ENABLE_Zoltan2:BOOL=ON 
>>     -D Trilinos_ENABLE_Fortran:BOOL=OFF     -D TPL_ENABLE_MPI:BOOL=ON 
>>     -D Trilinos_ENABLE_ALL_OPTIONAL_PACKAGES=OFF ~/src/trilinos
>>
>> (Using master branch from today)
>>
>> But this results in errors from cmake because
>> packages/claps
>> packages/rbgen
>> packages/aristos
>> packages/Feapp
>>
>> don’t exist in the git checkout
>>
>> Removing them from the PackagesList.cmake gets the build going.
>>
>> When building zoltan2, pamgen is compiled. It seems that the 
>> pamgenmeshadaptor pulls in this dependency. Should this not be 
>> enabled only if the user has explicitly requested pamgen – or did I 
>> miss an option to disable this part of the build?
>>
>> Yours
>>
>> JB
>>
>>
>>
>>
>> _______________________________________________
>> Trilinos-Users mailing list
>> Trilinos-Users at software.sandia.gov
>> https://software.sandia.gov/mailman/listinfo/trilinos-users
>


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://software.sandia.gov/pipermail/trilinos-users/attachments/20150220/de446b2c/attachment-0001.html>