[Trilinos-Users] Patch submission process
nate at nateroberts.com
Fri Aug 26 14:57:22 EDT 2016
Thanks, Carlos. That was quite helpful. I've now issued my first two pull requests.
For anyone else who might be new to this, here was my process:
1. Create my own fork of Trilinos in GitHub.
2. Create a new branch within the fork, corresponding to a single pull request.
3. Apply changes.
4. Create a pull request (using "compare across forks"), with the official Trilinos repo as base, and my fork as head.
I submitted to Trilinos's "master" branch, but I think the better thing would have been to submit to "develop," based on Denis Ridzal's comment on one of the pull requests. (I may end up closing and recreating to submit to develop.)
> On Aug 26, 2016, at 11:21 AM, Carlos Reyes <carlos at stellarscience.com> wrote:
> The standard method on GitHub to submit patches to a project is by using a pull request. General documentation on the subject can be found here:
> You can find a list of the pull requests for Trilinos awaiting processing here:
> Individual projects often have an additional set of requirements before they will consider incorporating the code patches contained in a pull request. I did not see a specific set of guidelines for Trilinos, but it won't hurt to familiarize yourself with the project policies:
> Carlos Reyes
> 1-505-206-1569 (mobile)
> On 08/25/2016 10:07 AM, Roberts, Nathan V. wrote:
>> Hello all,
>> Before the transition to the GitHub repo, there was a documented process for submitting patches. A couple patches I submitted this way seem to have gotten lost in the transition. So, I'd like to resubmit these, as well as a couple new ones.
>> Is the process for submitting patches to the GitHub repo documented somewhere?
>> Trilinos-Users mailing list
>> Trilinos-Users at trilinos.org
> Trilinos-Users mailing list
> Trilinos-Users at trilinos.org
More information about the Trilinos-Users