[Trilinos-Users] minor bug report

Wed Mar 4 14:55:57 MST 2015

JB:  Ross Bartlett is going to fix this problem in TriBITS.  Here is the issue report at GitHub. Thanks for reporting this problem. --Karen

[TriBITS] Packages required only for tests are built even when tests are disabled (#56)
https://github.com/TriBITSPub/TriBITS/issues/56#issuecomment-77254388

From: <Biddiscombe>, "John A." <biddisco at cscs.ch<mailto:biddisco at cscs.ch>>
Date: Friday, February 20, 2015 at 3:09 PM
To: kddevin <kddevin at sandia.gov<mailto:kddevin at sandia.gov>>, "Prokopenko, Andrey (-EXP)" <aprokop at sandia.gov<mailto:aprokop at sandia.gov>>
Cc: "trilinos-users at software.sandia.gov<mailto:trilinos-users at software.sandia.gov>" <trilinos-users at software.sandia.gov<mailto:trilinos-users at software.sandia.gov>>
Subject: Re: [Trilinos-Users] [EXTERNAL] minor bug report

I see that Galeri is also being pulled in by the testing
TEST_REQUIRED_DEP_PACKAGES contains it, so I guess this is not being correctly handled when testing is off. I moved it to TEST_OPTIONAL_DEP_PACKAGES and now it is not built, but I don't really know where these vars are used. I suspect my patch from earlier is doing the wrong thing and as you say, no guard is required, just a fix to the test dependencies...

[It's not very serious anyway. I just wanted to minimize the code compiled so I could experiment and have less dependencies to worry about.]

Yours

JB

From: <Biddiscombe>, cscs <biddisco at cscs.ch<mailto:biddisco at cscs.ch>>
Date: Friday 20 February 2015 22:29
To: Karen Devine <kddevin at sandia.gov<mailto:kddevin at sandia.gov>>, "Prokopenko, Andrey (-EXP)" <aprokop at sandia.gov<mailto:aprokop at sandia.gov>>
Cc: "trilinos-users at software.sandia.gov<mailto:trilinos-users at software.sandia.gov>" <trilinos-users at software.sandia.gov<mailto:trilinos-users at software.sandia.gov>>
Subject: Re: [Trilinos-Users] [EXTERNAL] minor bug report

Andrey, Karen

Thanks for the  Trilinos_ASSERT_MISSING_PACKAGES=OFF, this works as expected. For the Pamgen, dependency, I added an option. here's a patch, should you want to use it.

Yours

JB

From: <Devine>, Karen Devine <kddevin at sandia.gov<mailto:kddevin at sandia.gov>>
Date: Friday 20 February 2015 22:23
To: "Prokopenko, Andrey (-EXP)" <aprokop at sandia.gov<mailto:aprokop at sandia.gov>>, cscs <biddisco at cscs.ch<mailto:biddisco at cscs.ch>>
Cc: "trilinos-users at software.sandia.gov<mailto:trilinos-users at software.sandia.gov>" <trilinos-users at software.sandia.gov<mailto:trilinos-users at software.sandia.gov>>
Subject: RE: [Trilinos-Users] [EXTERNAL] minor bug report

Thanks for your quick response to John, Andrey.

You are correct that Trilinos_ASSERT_MISSING_PACKAGES=OFF is needed.

Pamgen is a required dependence only for Zoltan2's testing. It is needed only when Zoltan2_ENABLE_TESTS=ON. I am checking with the frameworks people about why Pamgen is enabled even when Zoltan2_ENABLE_TESTS=OFF.

Zoltan2_PamgenMeshAdapter.hpp requires Pamgen, but it is included only by test programs that are not compiled when Zoltan2_ENABLE_TESTS=OFF. Also, Zoltan2_PamgenMeshAdapter.hpp does not control the build of Pamgen; that happens at the CMake/Tribits level. So I don't think additional guards are needed (although they wouldn't hurt anything either).

Thanks again.

Karen

________________________________
From:trilinos-users-bounces at software.sandia.gov<mailto:trilinos-users-bounces at software.sandia.gov> <trilinos-users-bounces at software.sandia.gov<mailto:trilinos-users-bounces at software.sandia.gov>> on behalf of Andrey Prokopenko <aprokop at sandia.gov<mailto:aprokop at sandia.gov>>
Sent: Friday, February 20, 2015 10:24 AM
To: Biddiscombe, John A.
Cc: trilinos-users at software.sandia.gov<mailto:trilinos-users at software.sandia.gov>
Subject: Re: [Trilinos-Users] [EXTERNAL] minor bug report

Hi John,

To ignore missing packages (like claps in your case), add
  -D Trilinos_ASSERT_MISSING_PACKAGES=OFF
to your configure line.

Regarding Zoltan2, I'm not sure. The Dependencies.cmake has only Zoltan2 tests requiring pamgen, but the src/input is unconditionally compiled. I think you are right, and the pamgen mesh adapter should be guarded with something like HAVE_ZOLTAN2_PAMGEN.

-Andrey
On 02/20/2015 03:14 AM, Biddiscombe, John A. wrote:
Wanting to build zoltan2 without everything else, I tried

cmake  -D BUILD_TESTING:BOOL=OFF   -D Trilinos_ENABLE_Zoltan2:BOOL=ON     -D Trilinos_ENABLE_Fortran:BOOL=OFF     -D TPL_ENABLE_MPI:BOOL=ON     -D Trilinos_ENABLE_ALL_OPTIONAL_PACKAGES=OFF ~/src/trilinos

(Using master branch from today)

But this results in errors from cmake because
packages/claps
packages/rbgen
packages/aristos
packages/Feapp

don't exist in the git checkout

Removing them from the PackagesList.cmake gets the build going.

When building zoltan2, pamgen is compiled. It seems that the pamgenmeshadaptor pulls in this dependency. Should this not be enabled only if the user has explicitly requested pamgen - or did I miss an option to disable this part of the build?

Yours

JB

_______________________________________________
Trilinos-Users mailing list
Trilinos-Users at software.sandia.gov<mailto:Trilinos-Users at software.sandia.gov>https://software.sandia.gov/mailman/listinfo/trilinos-users

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://software.sandia.gov/pipermail/trilinos-users/attachments/20150304/2bbbbf12/attachment.html>