[Trilinos-Users] [EXTERNAL] [11.2.1] EpetraExt tests fail to compile w Clang

[Denis Davydov]

Dear Irina,

I just learned that those compiler errors are still there in 12.4.2.
Do you mind applying them to the master and thereby fixing it?

Kind regards,
Denis 

—
diff --git a/packages/didasko/examples/hypre/hypre_Helpers.cpp b/packages/didasko/examples/hypre/hypre_Helpers.cpp
index 1bf1b2c..793e218 100644
--- a/packages/didasko/examples/hypre/hypre_Helpers.cpp
+++ b/packages/didasko/examples/hypre/hypre_Helpers.cpp
@@ -60,7 +60,7 @@
 
 using Teuchos::RCP;
 using Teuchos::rcp;
-EpetraExt_HypreIJMatrix::EpetraExt_HypreIJMatrix* newHypreMatrix(const int N)
+EpetraExt_HypreIJMatrix* newHypreMatrix(const int N)
 {
   HYPRE_IJMatrix Matrix;
   int ierr = 0;
@@ -117,7 +117,7 @@ EpetraExt_HypreIJMatrix::EpetraExt_HypreIJMatrix* newHypreMatrix(const int N)
   return RetMat;
 }
 
-Epetra_CrsMatrix::Epetra_CrsMatrix* newCrsMatrix(int N){
+Epetra_CrsMatrix* newCrsMatrix(int N){
 
   Epetra_MpiComm Comm(MPI_COMM_WORLD);
 
@@ -138,7 +138,7 @@ Epetra_CrsMatrix::Epetra_CrsMatrix* newCrsMatrix(int N){
   return Matrix;
 }
 
-Epetra_CrsMatrix::Epetra_CrsMatrix* GetCrsMatrix(EpetraExt_HypreIJMatrix *Matrix)
+Epetra_CrsMatrix* GetCrsMatrix(EpetraExt_HypreIJMatrix *Matrix)
 {
   int N = Matrix->NumGlobalRows();
   Epetra_CrsMatrix* TestMat = new Epetra_CrsMatrix(Copy, Matrix->RowMatrixRowMap(), Matrix->RowMatrixColMap(), N, false);
diff --git a/packages/didasko/examples/hypre/hypre_Helpers.hpp b/packages/didasko/examples/hypre/hypre_Helpers.hpp
index 930719e..70ac59f 100644
--- a/packages/didasko/examples/hypre/hypre_Helpers.hpp
+++ b/packages/didasko/examples/hypre/hypre_Helpers.hpp
@@ -51,11 +51,11 @@
 
 #include <string>
 
-EpetraExt_HypreIJMatrix::EpetraExt_HypreIJMatrix* newHypreMatrix(int N);
+EpetraExt_HypreIJMatrix* newHypreMatrix(int N);
 
-Epetra_CrsMatrix::Epetra_CrsMatrix* newCrsMatrix(int N);
+Epetra_CrsMatrix* newCrsMatrix(int N);
 
-Epetra_CrsMatrix::Epetra_CrsMatrix* GetCrsMatrix(EpetraExt_HypreIJMatrix &Matrix);
+Epetra_CrsMatrix* GetCrsMatrix(EpetraExt_HypreIJMatrix &Matrix);
 
 bool EquivalentVectors(Epetra_MultiVector &X, Epetra_MultiVector &Y, double tol);


> On 13 Jul 2015, at 17:30, Irina Demeshko <ipdemes at sandia.gov> wrote:
> 
> Hi Denis,
> 
> Thank you for the patch!
> 
> Irina
> 
> On 07/10/2015 11:56 PM, Denis Davydov wrote:
>> Hi,
>> 
>> yes, this patch below solved the issue.
>> 
>> Regards,
>> Denis.
>> 
>> 
>> 
>> diff --git a/packages/didasko/examples/hypre/hypre_Helpers.hpp b/packages/didasko/examples/hypre/hypre_Helpers.hpp
>> index 930719e..70ac59f 100644
>> --- a/packages/didasko/examples/hypre/hypre_Helpers.hpp
>> +++ b/packages/didasko/examples/hypre/hypre_Helpers.hpp
>> @@ -51,11 +51,11 @@
>>    #include <string>
>>  -EpetraExt_HypreIJMatrix::EpetraExt_HypreIJMatrix* newHypreMatrix(int N);
>> +EpetraExt_HypreIJMatrix* newHypreMatrix(int N);
>>  -Epetra_CrsMatrix::Epetra_CrsMatrix* newCrsMatrix(int N);
>> +Epetra_CrsMatrix* newCrsMatrix(int N);
>>  -Epetra_CrsMatrix::Epetra_CrsMatrix* GetCrsMatrix(EpetraExt_HypreIJMatrix &Matrix);
>> +Epetra_CrsMatrix* GetCrsMatrix(EpetraExt_HypreIJMatrix &Matrix);
>>    bool EquivalentVectors(Epetra_MultiVector &X, Epetra_MultiVector &Y, double tol);
>> 
>> 
>>> On 10 Jul 2015, at 22:36, Irina Demeshko <ipdemes at sandia.gov> wrote:
>>> 
>>> Hi Denis,
>>> 
>>> Could you, please, try to do next in your didashko examples:
>>> 
>>> EpetraExt_HypreIJMatrix* newHypreMatrix(int N);
>>> Epetra_CrsMatrix* newCrsMatrix(int N);
>>> 
>>> instead of
>>> 
>>> EpetraExt_HypreIJMatrix::EpetraExt_HypreIJMatrix* newHypreMatrix(int N);
>>> Epetra_CrsMatrix::Epetra_CrsMatrix* newCrsMatrix(int N);
>>> 
>>> Best regards,
>>> 
>>> Irina
>>> 
>>> 
>>> On 07/10/2015 02:14 PM, Denis Davydov wrote:
>>>> EpetraExt_HypreIJMatrix::EpetraExt_HypreIJMatrix* newHypreMatrix(int N);
>