[Trilinos-Users] Epetra rectangular matrix
Salinger, Andrew
agsalin at sandia.gov
Mon Mar 31 11:22:55 MDT 2014
David,
Here are some things I saw on a quick read-through:
1. Best to over-estimate NumNzPerRow so that it doesn't have to re-allocate more memory. You may even know this number exactly (using m_matching.size())
2. check return code on InsertGlobalValues — indices must be in maps or you'll later get NaNs.
3. I don't think FillComplete needs arguments.
4. MatrixVectorProduct should not need "matrix" argument but use m_matrix
5. MatrixVectorProduct input and output, weird that one is std::vector<double> and other double*. Pick one.
6. outputEpetraVector can be made a View of double* output, so you don't need the final copy loop.
Not sure exactly what you want — hope this helps.
Andy
From: <Day>, David <dmday at sandia.gov<mailto:dmday at sandia.gov>>
Date: Monday, March 31, 2014 10:01 AM
To: "trilinos-users at software.sandia.gov<mailto:trilinos-users at software.sandia.gov>" <trilinos-users at software.sandia.gov<mailto:trilinos-users at software.sandia.gov>>
Subject: [Trilinos-Users] Epetra rectangular matrix
Dear Trilinos Developers,
I am a customer of Trilinos. The team that I work on is using Epetra to generate and apply a serial rectangular matrix. I have attached a more than minimal version of the related source code (I left out a couple peripheral definitions). I would appreciate it if a Trilinos developer could review and provide feedback on the code.
Very best regards,
David Day
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://software.sandia.gov/pipermail/trilinos-users/attachments/20140331/7c0f7a5c/attachment.html>
More information about the Trilinos-Users
mailing list